Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual_ipaddress should be on vrrp interface if use_vmac is set #186

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

saz
Copy link
Sponsor Contributor

@saz saz commented Jun 26, 2019

Virtual ip addresses should be setup on vrrp interface if use_vmac is set

@saz saz force-pushed the use_vmac_vrrp_interface branch from 9b5a74b to 03661fd Compare June 26, 2019 15:31
@saz
Copy link
Sponsor Contributor Author

saz commented Jun 26, 2019

I've just realised, that virtual_ipaddress_excluded should be handled the same way. I'll update this PR asap

@saz saz force-pushed the use_vmac_vrrp_interface branch from 03661fd to a664ade Compare June 27, 2019 09:39
@saz saz force-pushed the use_vmac_vrrp_interface branch from a664ade to a324c7b Compare June 27, 2019 15:44
@saz
Copy link
Sponsor Contributor Author

saz commented Jun 27, 2019

If tests are successful, this PR should be complete

@saz
Copy link
Sponsor Contributor Author

saz commented Jun 28, 2019

The failing test seems to be something else.

@saz
Copy link
Sponsor Contributor Author

saz commented Sep 25, 2019

Any news on this one?

@bastelfreak bastelfreak added the bug Something isn't working label Sep 25, 2019
@bastelfreak bastelfreak merged commit 5ab0d63 into voxpupuli:master Sep 25, 2019
@saz
Copy link
Sponsor Contributor Author

saz commented Sep 25, 2019

Thanks @bastelfreak

@Dan33l Dan33l mentioned this pull request Oct 22, 2019
@igalic igalic mentioned this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants