Change set_parameter to be an array of strings #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZloeSabo
force-pushed
the
feature/make-set-parameter-array
branch
from
8b58b19
to
1be9694
Compare
bastelfreak
reviewed
Oct 6, 2020
bastelfreak
added
enhancement
bastelfreak
reviewed
Oct 6, 2020
ZloeSabo
force-pushed
the
feature/make-set-parameter-array
branch
from
82d5b42
to
7f3b670
Compare
ZloeSabo
force-pushed
the
feature/make-set-parameter-array
branch
from
7f3b670
to
cec8591
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This changes
set_parameterto be an array of strings instead of a single string. setParameter config setting can contain multiple parameters and also requires indentation for them. So with a string-typed parameter, workarounds were required to achieve a proper structure (example) with newlines and indentation. The current PR fixes that problem.This Pull Request (PR) fixes the following issues