Fixes for ubuntu support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 20, 2017 20:28
…u may fall back to the host+port
…tart the daemon (#20)
Closed
bastelfreak
reviewed
Mar 20, 2017
| $admin_listen_socket = '/tmp/proxysql_admin.sock' | ||
| $package_provider = 'dpkg' | ||
| $sys_owner = 'root' | ||
| $sys_group = 'root' | ||
| } | ||
| 'Ubuntu': { | ||
| $admin_listen_socket = '/tmp/proxysql_admin.sock' |
There was a problem hiding this comment.
is it a good idea to put a socket to /tmp?
There was a problem hiding this comment.
/tmp is the upstream ProxySQL default...
bastelfreak
reviewed
Mar 20, 2017
| @@ -2,8 +2,11 @@ | |||
| prompt = 'Admin> ' | |||
|
|
|||
| [client] | |||
| <% if scope.lookupvar('::proxysql::admin_listen_socket') != '' -%> | |||
There was a problem hiding this comment.
can we work with undef so this works?
<% if scope.lookupvar('::proxysql::admin_listen_socket') -%>There was a problem hiding this comment.
I've been working on this last night but I couldn't get it to work with undef.
The parameter is currently defined as:
String $admin_listen_socket = $::proxysql::params::admin_listen_socket
The default in params is:
$admin_listen_socket = '/tmp/proxysql_admin.sock'
When I change the definition to:
Variant[String, Undef] $admin_listen_socket = $::proxysql::params::admin_listen_socket
Then I can do:
class { '::proxysql':
admin_listen_socket => undef,
}
but that will go on and use the default /tmp/proxysql_admin.sock.
Either I leave it like this or I remove the if and the entire else case and we don't support an empty $admin_listen_sock...
…module to be functional.
|
@bastelfreak could you try to find some time to finish your review here? thnx ;) |
|
ah sure! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-proxysql
that referenced
this pull request
Aug 22, 2023
Fixes for ubuntu support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move fixes to seperate PR as request in #19.