switch to structured facts for os* and rabbitmq_version #579
Conversation
|
May have to rebase this anyway after #581 |
wyardley
force-pushed
the
update_facts
branch
3 times, most recently
from
f691e76
to
dba010d
Compare
|
@alexjfisher rebased, also updated stuff for @ekohl's recent changes and acceptance tests to use structured facts. |
manifests/config.pp
Outdated
| 'Debian': { | ||
| if versioncmp($::operatingsystemmajrelease, '16.04') >= 0 { | ||
| if versioncmp($facts['os']['release']['major'], '16.04') >= 0 { |
There was a problem hiding this comment.
I know this is a 1-to-1 conversion but the major is 16 so does that mean it'll only be true for 17.04? Maybe the ['full'] fact would be better.
Things might also need explicit Debian/Ubuntu checks if you add Debian 9 to the mix but that's for later.
There was a problem hiding this comment.
maybe we should just do major => 16?
I don't think the module supports 16 yet, though we should add support for it (someone was asking for it this morning)
There was a problem hiding this comment.
Though I guess it should eval true anyway because it's versioncmp()? I'll just switch to full assuming tests pass.
Would be great if someone could update the acceptance tests for 16.x
There was a problem hiding this comment.
Updated in new version
wyardley
force-pushed
the
update_facts
branch
from
dba010d
to
1c42f42
Compare
switch to structured facts for os* and rabbitmq_version
switch to structured facts for os* and rabbitmq_version
This is failing one test currently