Fix usage of non-existent $selinux_enabled fact #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If selinux is disabled on a host only the $::selinux (new: $::os['selinux']['enabled']) fact is available. To be able to delete them in the spec test they don't need to be listed in the defaults_(module_)?facts.yaml files.
The fact is in fact called $::selinux not $::selinux_enabled. It was not caught by the spec test because it was specified in default_module_facts.yaml. And there is only a WIP accetpance test for disabled to enforcing switch which will check this too in future.
|
thanks! |
EmRowlands
pushed a commit
to EmRowlands/puppet-selinux
that referenced
this pull request
Mar 29, 2023
Fix usage of non-existent $::selinux_enabled fact
smortex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact is in fact called$::selinux not $ ::selinux_enabled.
It was not caught by the spec test because it was specified in
default_module_facts.yaml.
And there is only a WIP accetpance test for disabled to enforcing
switch which will check this too in future.
The existing acceptance tests for centos-72-x64 and
centos-66-x64 discovered no problems with this PR.