modulesync 2.5.1 and drop Puppet 4 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now has a merge conflict |
bastelfreak
force-pushed
the
modulesync
branch
from
b0bcce9
to
2739395
Compare
ekohl
reviewed
Feb 28, 2019
ekohl
reviewed
Feb 28, 2019
bastelfreak
force-pushed
the
modulesync
branch
3 times, most recently
from
ef68ff2
to
5d1034a
Compare
ekohl
approved these changes
Feb 28, 2019
bastelfreak
force-pushed
the
modulesync
branch
from
5d1034a
to
9f773b3
Compare
ekohl
reviewed
Feb 28, 2019
| @@ -9,7 +9,8 @@ | |||
| osfamily: 'RedHat', | |||
There was a problem hiding this comment.
You can drop the old facts here if you want.
|
@ekohl IMO merging this and doing a major release is fine, that's wha we agreed on in voxpupuli/voxpupuli.github.io#157 |
|
@bastelfreak I'd prefer to do a release, bump major and then wait for other changes to come in |
|
Based on our conversation in voxpupuli/voxpupuli.github.io#157, we wanted to not ever do a release just for removing puppet 4. As such, I'm ok with this PR, @ekohl. Doing a minor/patch release to prepare for a major release change that removes Puppet 4 is exactly what the community agreed to avoid doing. |
dhollinger
approved these changes
Mar 3, 2019
EmRowlands
pushed a commit
to EmRowlands/puppet-selinux
that referenced
this pull request
Mar 29, 2023
modulesync 2.5.1 and drop Puppet 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modulesync 2.5.1