add support for selinux login #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jul 19, 2022
manifests/init.pp
Outdated
| @@ -89,6 +91,9 @@ | |||
| if $exec_restorecon { | |||
| create_resources ( 'selinux::exec_restorecon', $exec_restorecon ) | |||
| } | |||
| if $login { | |||
There was a problem hiding this comment.
while this style is consistent with the rest of the class, it doesn't meet best practices. using create_resources is deprecated. Instead I sugges to default $login to an empty hash and iterate on it
$login.each |$login_name, $login_attributes {
selinux::login { $login_name:
* => $login_attributes,
}
}There was a problem hiding this comment.
you can drop the if $login. $login.each will notice that $login is empty and not iterate on it.
bastelfreak
reviewed
Jul 19, 2022
manifests/login.pp
Outdated
| # @param selinux_user The selinux user to map to | ||
| # | ||
| define selinux::login ( | ||
| String $selinux_login_name, |
There was a problem hiding this comment.
can you make the datatypes more strict? At the moment they would allow empty strings:
Suggested change
| String $selinux_login_name, | |
| String[1] $selinux_login_name, |
There was a problem hiding this comment.
Yep.. sorry I'm lacking in experience with Ruby.
added 2 commits
July 19, 2022 14:32
bastelfreak
reviewed
Jul 21, 2022
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
|
thanks for the work! |
EmRowlands
pushed a commit
to EmRowlands/puppet-selinux
that referenced
this pull request
Mar 29, 2023
* add support for selinux login * cleanup linting * documented param for login * remove empty line * remove useless vars * use to_s * add in fixes for PR review * add | * Update manifests/init.pp Co-authored-by: Tim Meusel <tim@bastelfreak.de> * drop if statement Co-authored-by: Brock Shelton <brock.shelton@oracle.com> Co-authored-by: Tim Meusel <tim@bastelfreak.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This is a PR to add basic support for selinux logins. This will allow mapping of linux users or groups to a selinux user.
This Pull Request (PR) fixes the following issues
Fixes #166