Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedora support #43

Merged
merged 1 commit into from
Jun 16, 2015
Merged

Conversation

jhoblitt
Copy link
Member

Based on #42

@jhoblitt
Copy link
Member Author

Rebased on current master as #42 has been merged.

jfryman added a commit that referenced this pull request Jun 16, 2015
@jfryman jfryman merged commit 0ab38c1 into voxpupuli:master Jun 16, 2015
@jhoblitt
Copy link
Member Author

👏

@mgoodness
Copy link

This has broken CentOS support.

@jhoblitt
Copy link
Member Author

@mgoodness What version of centos? What version of puppet? What version of facter? What is the error message?

@jhoblitt
Copy link
Member Author

I think I see the problem, the case statement on $::operatingsystem needs to default to everything but fedora.

@mgoodness
Copy link

Apologies for the lack of detail.

CentOS 6.6, Puppet 3.8.1, Facter 2.4.4
Error is "CentOS is not supported". I believe the $::operatingsystem case statement is the cause, yes.

jhoblitt added a commit to jhoblitt/puppet-selinux that referenced this pull request Jun 16, 2015
@jhoblitt
Copy link
Member Author

@mgoodness Could you give #44 a try?

@mgoodness
Copy link

LGTM. Thank you, sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants