require PSH 5.x, require puppet-strings #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested that at voxpupuli/puppet-yum#297 |
Codecov ReportBase: 1.63% // Head: 1.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
======================================
Coverage 1.63% 1.63%
======================================
Files 2 2
Lines 61 61
======================================
Hits 1 1
Misses 60 60 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Also contains #85 |
jhoblitt
approved these changes
Feb 9, 2023
This now uses a similar setup as puppet-syntax. Sideeffect is that for Puppet 6 tests, we pull in the 6.29 version or newer, which has a fix to pin to concurrent-ruby 1.1 and older.
with the release of puppetlabs_spec_helper 5, it can validate the REFERENCE.md. It won't pull in puppet-strings automatically, so the dependency needs to be added. The `strings:validate:reference` task is called within `validate`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the release of puppetlabs_spec_helper 5, it can validate the REFERENCE.md. It won't pull in puppet-strings automatically, so the dependency needs to be added. The
strings:validate:referencetask is called withinvalidate.