Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRAN submission erros, some chores #4

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Conversation

vst
Copy link
Owner

@vst vst commented Dec 6, 2022

Closes #3.

  • chore(dev): re-configure Nix environment
  • chore: bump development version to 0.0.3.9000
  • fix: attend roxygen2 warning
  • fix: register native routines
  • fix: use autonewsmd to auto-generate NEWS.md file
  • chore(dev): add aspell with "en" dictionaries to Nix development shell

- All important Nix expressions are now under `./nix/default.nix`.
- Switched from telos.nix to vanilla nixpkgs (branch `release-22.11`).
Fixed the warning during `devtools::check`. The warning was:

```
Warning: roxygen2 requires Encoding: "UTF-8"
```
We used to get a NOTE during `devtools::check`. This commit fixes it.

As a reference, the NOTE was:

```
File ‘mgarchBEKK/libs/mgarchBEKK.so’:
  Found no calls to: ‘R_registerRoutines’, ‘R_useDynamicSymbols’

It is good practice to register native routines and to disable symbol
search.

See ‘Writing portable packages’ in the ‘Writing R Extensions’ manual.
```

Following resources helped:

- https://ironholds.org/registering-routines/
- https://stackoverflow.com/questions/42313373/r-cmd-check-note-found-no-calls-to-r-registerroutines-r-usedynamicsymbols
- https://stackoverflow.com/questions/8407615/adding-usedynlib-through-roxygen
@vst vst linked an issue Dec 6, 2022 that may be closed by this pull request
@vst vst added the bug label Dec 6, 2022
@vst vst self-assigned this Dec 6, 2022
@vst vst merged commit 7cbc04e into main Dec 6, 2022
@vst vst deleted the 3-fix-cran-submission-errors branch December 6, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CRAN submission errors
1 participant