Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mapCoverage as it is deprecated #1314

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

termosa
Copy link

@termosa termosa commented Feb 25, 2018

mapCoverage has been deprecated since Jest@22.4.0
https://github.com/facebook/jest/blob/master/CHANGELOG.md#2240
jestjs/jest#5177

Copy link
Contributor

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😀

@LinusBorg
Copy link
Contributor

Has it been deprecated or removed? Is it still required for versions before 22.4?

Wouldn't that be a breaking change?

We would at least have to bump the dependency on package.json accordingly.

@LinusBorg LinusBorg closed this Mar 1, 2018
@LinusBorg LinusBorg reopened this Mar 1, 2018
@eddyerburgh
Copy link
Contributor

eddyerburgh commented Mar 1, 2018

Yes, you're right @LinusBorg . This PR should update Jest to 22.4.2.

@termosa
Copy link
Author

termosa commented Mar 1, 2018

Thank you! Fixed.
@LinusBorg @eddyerburgh

@LinusBorg
Copy link
Contributor

Thanks. FYI I'm moving this weekend so it might take some days till I get to merge and release this and other prs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants