Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I want to add a new Context Menu component witch named vue-mouse-menu #1283

Merged
merged 1 commit into from
Jul 14, 2017
Merged

I want to add a new Context Menu component witch named vue-mouse-menu #1283

merged 1 commit into from
Jul 14, 2017

Conversation

zgj233
Copy link
Contributor

@zgj233 zgj233 commented Jul 14, 2017 •
edited
Loading

  • LGTM
    I'm sorry I'm not good at English.
    This is my first open source project.
    I've added "- [] LGTM".
    Can you let me pass the review?

nickmessing
nickmessing approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@nickmessing nickmessing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Looks like you could use a PR to fix english language :) I'll do one.

@nickmessing nickmessing requested a review from kazupon July 14, 2017 05:42
@zgj233
Copy link
Contributor Author

zgj233 commented Jul 14, 2017

  • LGTM

@kazupon kazupon merged commit b1e59c5 into vuejs:master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

@nickmessing nickmessing nickmessing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zgj233 @kazupon @nickmessing