Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Suspense): delay update nested suspensible child if parent suspense is not resolved #10066

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jan 10, 2024

close #10042

play

Copy link

github-actions bot commented Jan 10, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.6 kB (+243 B) 34.3 kB (+90 B) 30.9 kB (+69 B)
vue.global.prod.js 146 kB (+243 B) 53.7 kB (+84 B) 47.8 kB (+125 B)

Usages

Name Size Gzip Brotli
createApp 51.6 kB (+241 B) 20.2 kB (+80 B) 18.3 kB (+84 B)
createSSRApp 54.9 kB (+241 B) 21.5 kB (+81 B) 19.6 kB (+73 B)
defineCustomElement 53.9 kB (+241 B) 21 kB (+85 B) 19 kB (+56 B)
overall 65.3 kB (+253 B) 25.2 kB (+102 B) 22.8 kB (+103 B)

@edison1105 edison1105 changed the title fix(Suspense): avoid unmount nested Suspense if parent suspense is not resolved fix(Suspense): delay unmount nested Suspense if parent suspense is not resolved Jan 10, 2024
@719media
Copy link

719media commented Feb 3, 2024

Thanks for coding this fix, anything I can do to test/help it along?

@edison1105 edison1105 changed the title fix(Suspense): delay unmount nested Suspense if parent suspense is not resolved fix(Suspense): delay update nested suspensible child if parent suspense is not resolved Feb 5, 2024
@edison1105
Copy link
Member Author

edison1105 commented Feb 5, 2024

@719media
Sorry, because I have been busy recently, this PR has not been completed yet.
I'll get it done later.

Done~

@edison1105 edison1105 marked this pull request as ready for review February 6, 2024 02:36
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Feb 6, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success failure
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@719media
Copy link

719media commented Mar 8, 2024

Great, thanks for all your help on this :)

@edison1105 edison1105 added 🐞 bug Something isn't working ready for review This PR requires more reviews labels Apr 3, 2024
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot

This comment was marked as outdated.

@719media
Copy link

Don't forget about this important issue! Could it be added to https://github.com/orgs/vuejs/projects/13 ?

@yyx990803
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Jul 11, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ready for review This PR requires more reviews scope: suspense
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

Nested child routes and using <suspense>
4 participants