fix(runtime-core): fix watch immediate error not captured in effectscope #8397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghaoSu
force-pushed
the
fix/error-capture-in-effect-scope
branch
from
dabb397
to
b468cb9
Compare
|
It looks like the underlying problem was fixed by #9948. I tried running the test case added in this PR and it does pass since that PR was merged. That PR didn't add any test cases for the specific scenario being handled here, so perhaps this PR could be repurposed just to add the relevant tests? |
linghaoSu
force-pushed
the
fix/error-capture-in-effect-scope
branch
from
b468cb9
to
a6e8f49
Compare
Size ReportBundles
Usages
|
It's great to see that this issue has been fixed, removing the previous fix and leaving only the test code in place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8284