Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): functions returned should not support reuse #9850

Closed
wants to merge 1 commit into from
Closed

fix(runtime-dom): functions returned should not support reuse #9850

wants to merge 1 commit into from

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #9849

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87 kB (-54 B) 33.1 kB (-21 B) 29.9 kB (-15 B)
vue.global.prod.js 133 kB (-54 B) 49.9 kB (-16 B) 44.7 kB (-14 B)

Usages

Name Size Gzip Brotli
createApp 48.4 kB 19 kB 17.4 kB
createSSRApp 51.6 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.8 kB 18.1 kB
overall 61.7 kB 23.9 kB 21.7 kB

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 16, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #9850 will not alter performance

Comparing RicardoErii:fix/with-keys (9951051) with main (4e7967f)

Summary

✅ 53 untouched benchmarks

@yangxiuxiu1115 yangxiuxiu1115 changed the title fix(runtime-dom): functions returned by withKeys should not support r… fix(runtime-dom): functions returned should not support reuse Dec 16, 2023
@LinusBorg LinusBorg mentioned this pull request Dec 16, 2023
Merged
@yyx990803
Copy link
Member

Thanks for the PR but we do need to perform the caching - #9851 is the more appropriate fix.

@yyx990803 yyx990803 closed this Dec 16, 2023
@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/with-keys branch December 16, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested elements with key event+modifiers do not call listener function
2 participants
@yangxiuxiu1115 @yyx990803