feat(compiler): allow unicode characters for component name as described in #8564 #8666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use unicode letters when parsing path for watcher instead of only ascii letters - extract const `unicodeLetters` from html-parser to lang
|
In addition to #8564 , I added support for unicode property path in watcher. |
13 tasks
Justineo
reviewed
Dec 10, 2018
src/core/util/lang.js
Outdated
| /** | ||
| * unicode letters used for parsing html tags, component names and property paths. | ||
| * use https://www.w3.org/TR/html53/semantics-scripting.html#potentialcustomelementname | ||
| * except \u10000-\uEFFFF because of performance problem |
There was a problem hiding this comment.
I made a benchmark for this and it turns out that in most modern browsers except Safari, it runs fastest if we include \u10000-\uEFFFF:
There was a problem hiding this comment.
Well, in my computer, npm test failed because of timeout when including \u10000-\uEFFFF. It passed without the extra characters. I don't know why the performance difference exists, yet.
Co-Authored-By: youngrok <pak.youngrok@gmail.com>
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
… watch paths (vuejs#8666) close vuejs#8564
| // except \u10000-\uEFFFF because of performance problem | ||
| export const pcenchars = '[\\-\\.0-9_a-zA-Z\\u00B7\u00C0-\u00D6\u00D8-\u00F6\u00F8-\u037D\u037F-\u1FFF\u200C-\u200D\u203F-\u2040\u2070-\u218F\u2C00-\u2FEF\u3001-\uD7FF\uF900-\uFDCF\uFDF0-\uFFFD]' | ||
| const ncname = `[a-zA-Z_]${pcenchars}*` | ||
| const ncname = `[a-zA-Z_][\\-\\.0-9_a-zA-Z${unicodeLetters}]*` |
There was a problem hiding this comment.
'a-zA-Z' is repeat in unicodeLetters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #8564
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: