Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix($plugin-search): match non-ASCII chars (close #2242) #2283

Merged
merged 1 commit into from
Apr 8, 2020
Merged

fix($plugin-search): match non-ASCII chars (close #2242) #2283

merged 1 commit into from
Apr 8, 2020

Conversation

meteorlxy
Copy link
Member

@meteorlxy meteorlxy commented Apr 6, 2020 •
edited
Loading

Summary

Close #2242

  • If the query only has ASCII chars, treat it as English (keep current match algorithms)
  • If the query has non-ASCII chars, treat is as other languages (fallback to use indexOf as before)

Related to #1557

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

@meteorlxy meteorlxy mentioned this pull request Apr 6, 2020
Closed
@meteorlxy meteorlxy merged commit 9f3f49c into vuejs:master Apr 8, 2020
@meteorlxy meteorlxy deleted the fix/2242 branch April 8, 2020 06:59
@meteorlxy meteorlxy mentioned this pull request Apr 8, 2020
Closed
18 tasks
larionov pushed a commit to larionov/vuepress that referenced this pull request Aug 19, 2020
@meteorlxy
fix($plugin-search): match non-ASCII chars (close vuejs#2242) (vuejs#…
c3eb63f 
…2283)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kefranabg kefranabg kefranabg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change search plugin regular expression to support non-latin characters
2 participants
@meteorlxy @kefranabg