Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code line number (close: #365) #379

Merged
merged 26 commits into from
May 13, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6316058
feat: support line number
ulivz May 9, 2018
8c6f7c6
style: tweaks
ulivz May 9, 2018
d779750
refactor: simplify patch code
ulivz May 9, 2018
37c66a5
chore: tweaks
ulivz May 9, 2018
2b086d4
refactor: simplify code
ulivz May 9, 2018
4b19b86
refactor: hack line number middle align at all browsers
ulivz May 9, 2018
1e305e6
chore: add some comments
ulivz May 9, 2018
1b0ad8e
chore: rename highlightLines to line
ulivz May 9, 2018
eccf61a
chore: tweaks
ulivz May 9, 2018
54b4bad
Merge branch 'master' into line-number-support
ulivz May 10, 2018
ad58290
merge master
ulivz May 13, 2018
fa8aa12
chore: remove unexpected change
ulivz May 13, 2018
8352408
chore: remove unexpected change - 2
ulivz May 13, 2018
0a1b1d9
chore: chore: remove unexpected change - 3
ulivz May 13, 2018
0d27c4f
Merge branch 'master' into line-number-support
ulivz May 13, 2018
103da0c
chore: chore: chore: remove unexpected change - 4
ulivz May 13, 2018
8d1006e
Merge branch 'master' into line-number-support
ulivz May 13, 2018
a1f19b3
feat: hoist lineNumbers as a separate plugin
ulivz May 13, 2018
538ea1d
chore: tweaks
ulivz May 13, 2018
43072df
Merge branch 'master' into line-number-support
ulivz May 13, 2018
2f29ffa
Merge branch 'master' into line-number-support
ulivz May 13, 2018
b2702d1
style: enhancement
ulivz May 13, 2018
228f91e
refactor(pre-wrapper): change attr to class
ulivz May 13, 2018
be5d675
docs: add doc for line numbers
ulivz May 13, 2018
41f7362
chore: recover config.
ulivz May 13, 2018
3880629
fix: missing language tip
ulivz May 13, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into line-number-support
  • Loading branch information
ulivz committed May 13, 2018
commit 0d27c4f00b19ca2cc18d0a6661b333b3c7c53bf4
3 changes: 3 additions & 0 deletions lib/default-theme/styles/code.styl
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ div[class="language-c"]:before
div[class="language-bash"]:before
content "sh"

div[class="language-yaml"]:before
content "yaml"

$lineNumberWrapperWidth = 3rem

.content pre[line-number-mode]
Expand Down
3 changes: 1 addition & 2 deletions lib/markdown/highlightLines.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ module.exports = md => {
return `<div class="language-${langName}">${fence(...args)}</div>`
}

const langName = token.info.replace(RE, '').trim()
token.info = langName

const lineNumbers = RE.exec(token.info)[1]
Expand Down Expand Up @@ -54,6 +53,6 @@ module.exports = md => {
highlightedCode += `${split.code}\n`
}
})
return `<div class="language-${langName}">${highlightedCode}</div>`
return highlightedCode
}
}
You are viewing a condensed version of this merge commit. You can view the full changes here.