Infrastructure: Re-run npm run reference-tables and npm run coverage-report on source script update
#3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
added
the
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3024 (comment).
Currently, using
lint-staged, thenpm run reference-tablesandnpm run coverage-reportscripts are automatically ran when a git commit happens ONLY if files matchingcontent/patterns/**/examples/*.htmlhave been changed.The generating scripts have been overlooked in that automatic process so this PR adds those (
scripts/coverage-report.*andscripts/reference-tables.*). This should reduce any issues with theCheck examples/index.html / coveragecheck if only those script files have been updated in a PR.