Regression Tests: Enable disclosure_navigation.js test to scroll to element and click in executeScript context
#3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and align with existing scroll behavior in other tests
…nks to scroll to menus to reduce flakiness
howard-e
added
the
regression-testing
|
For revieiwers, I re-ran this test locally 50 times using I also re-ran the regression tests for this PR in CI 10 times without any errors being thrown. Unless something changes, I feel confident that this should remove the flakiness with the test described in #2996. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2996. The previous fix, #2997 didn't fully resolve the issue described in #2996 (comment).
Update
../tests/disclosure_navigation.js test > "aria-current" attribute on linksto scroll to link before click event and do click insideexecuteScript.WAI Preview Link (Last built on Mon, 01 Jul 2024 20:50:58 GMT).