Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-fully-active documents #219

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Handle non-fully-active documents #219

merged 2 commits into from
Sep 13, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Sep 3, 2021

Closes #218

For normative changes, the following tasks have been completed:

Implementation commitment:


Preview | Diff

@ewilligers
Copy link
Collaborator

Thank you for the work on this.

Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 that was quick

@marcoscaceres
Copy link
Member Author

Filed WebKit bug + sending patch.

Updated Gecko's patch for canShare() https://phabricator.services.mozilla.com/D90834

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Sep 9, 2021

Tests are up at web-platform-tests/wpt#30417

(update: fixed link)

Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with InvalidStateError.

@marcoscaceres marcoscaceres merged commit 94e7883 into main Sep 13, 2021
@marcoscaceres marcoscaceres deleted the fully-active-check branch September 13, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle documents not being fully active
3 participants