Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: canShare() return false if not allowed to use #220

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Sep 20, 2021

For normative changes, the following tasks have been completed:

Implementation commitment:


Preview | Diff

index.html Outdated Show resolved Hide resolved
Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@saschanaz
Copy link
Member

Do we have WPT for this BTW?

@marcoscaceres
Copy link
Member Author

I'll add one. No problem.

@saschanaz
Copy link
Member

BTW I'm not sure what the enum version of canShare be look like, if canShare covers more than just data check 🤔

@marcoscaceres
Copy link
Member Author

Added/fixed test:
web-platform-tests/wpt#30868

BTW I'm not sure what the enum version of canShare be look like, if canShare covers more than just data check 🤔

Happy to build on that aspect incrementally as a followup.

Irrespective, I think it would be confusing for ".canShare(x)" return true and then calling .share() to fail. That would not be great. This keeps them in sync.

@marcoscaceres marcoscaceres merged commit 1278880 into main Sep 20, 2021
@marcoscaceres marcoscaceres deleted the canShare-allowed branch September 20, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants