Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBrush follow-up delivery milestone 1(3 milestone for OpenBrush) #315

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

0xMarkian
Copy link
Contributor

@0xMarkian 0xMarkian commented Dec 2, 2021

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#621

We haven't filled the invoice form yet.
We did more progress than specified in the grant application.

What was specified:

We want to briefly(not full change, only minimal changes to reduce the size) implement them and provide a report(re-working data structure, reducing monomorphization, using dynamic dispatch in some cases).

In the description of the milestone, we mentioned that we're going to do "not full change,
only minimal changes to reduce the size", but we implemented them fully and it took more time.

Would it be possible to increase payment for that milestone from 9,000 USD to 15,000?

@Noc2
Copy link
Collaborator

Noc2 commented Dec 6, 2021

Thanks for the delivery. We will look into it as soon as possible.

@Noc2 Noc2 self-assigned this Dec 6, 2021
@Noc2
Copy link
Collaborator

Noc2 commented Dec 7, 2021

Thanks again. I’m happy to tell you that the milestone is hereby accepted. You can find my evaluation here.

Regarding amending the contract, I suggest creating a PR to update the contract. As part of the PR it would also be nice if you could tell us why you think your current delivery is worth 15k. For example, provide more information about how much work you put into it (hours).
Something to be aware of, is that we usually don’t do this often, because in most cases teams are working on their own projects and aren’t directly contributing to parity code.

@Noc2 Noc2 merged commit e89a320 into w3f:master Dec 7, 2021
@TtomaS7
Copy link
Contributor

TtomaS7 commented Dec 8, 2021

Thank you for the quick approve!

Good, we will create the pull request for the grant, and we will update information about the hours etc.

@TtomaS7
Copy link
Contributor

TtomaS7 commented Dec 9, 2021

The invoice is applied with updated information.

@Noc2
Copy link
Collaborator

Noc2 commented Dec 10, 2021

Thanks. I just forwarded the invoice internally.

@RouvenP
Copy link

RouvenP commented Dec 10, 2021

hi @TtomaS7 we transferred the payment today. Thanks!

@TtomaS7
Copy link
Contributor

TtomaS7 commented Dec 10, 2021

Thanks to you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants