Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info People and Coretime Chains #6102

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Conversation

filippoweb3
Copy link
Contributor

  • correct RPC calls Kusama
  • add RPC calls Polkadot
  • update RPC calls Wiki

Plus, see #6085

Task "More info on Account Identity and People chain"
Task "Coretime chain and People chain to the System chains page"

kusama people rpc wrongly implemented
@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label Jul 25, 2024
@filippoweb3 filippoweb3 self-assigned this Jul 25, 2024
@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Jul 25, 2024
Copy link
Contributor

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one tiny nit, and love the use of tabs

</TabItem>
<TabItem value="kusama">

Compared to Polkadot, Kusama does not have the Collectives system chain and it has the Encointer system chain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Compared to Polkadot, Kusama does not have the Collectives system chain and it has the Encointer system chain.
Compared to Polkadot, Kusama does not have the Collectives system chain, and it has the Encointer system chain.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filippoweb3 one thing - maybe before merging, we add a link to the Encointer chain?

@filippoweb3 filippoweb3 merged commit 98bd860 into master Jul 26, 2024
2 checks passed
@filippoweb3 filippoweb3 deleted the people-and-coretime-chain branch July 26, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants