Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HRMP Channel Establishment with System chains #6116

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Conversation

DrW3RK
Copy link
Member

@DrW3RK DrW3RK commented Jul 30, 2024

@DrW3RK DrW3RK self-assigned this Jul 30, 2024
@DrW3RK DrW3RK added the A1 - In Progress Not ready for review yet. label Jul 30, 2024
@DrW3RK DrW3RK requested a review from joepetrowski July 30, 2024 17:49
@DrW3RK DrW3RK added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Jul 30, 2024
docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
Comment on lines 67 to 68
For instance, the call to be executed on the relay chain to establish bi-directional channel between
a parachain with `ParaID` 4428 and the Asset Hub with `ParaID` 1000 is `0x3c0ae8030000`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the para ID matter in this call?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary. Removed it.

docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
DrW3RK and others added 3 commits July 31, 2024 13:25
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Copy link
Contributor

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just can't decode payload but maybe something from my end

docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
docs/build/build-hrmp-channels.md Show resolved Hide resolved
@CrackTheCode016 CrackTheCode016 self-requested a review August 7, 2024 13:58
@CrackTheCode016 CrackTheCode016 merged commit 1f876c9 into master Aug 7, 2024
3 checks passed
@CrackTheCode016 CrackTheCode016 deleted the hrmp-system branch August 7, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants