Skip to content

Commit

Permalink
Make pending requests test more specific
Browse files Browse the repository at this point in the history
This avoids the issue detailed in emberjs#458.
  • Loading branch information
wagenet committed Nov 7, 2018
1 parent 045ce3f commit 2e2f45c
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions tests/unit/teardown-context-test.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
import { module, test } from 'qunit';
import Service from '@ember/service';
import {
getContext,
setupContext,
teardownContext,
isSettled,
getSettledState,
} from '@ember/test-helpers';
import { getContext, setupContext, teardownContext, getSettledState } from '@ember/test-helpers';
import { setResolverRegistry } from '../helpers/resolver';
import hasEmberVersion from '@ember/test-helpers/has-ember-version';
import Ember from 'ember';
Expand Down Expand Up @@ -70,10 +64,9 @@ module('teardownContext', function(hooks) {

await teardownContext(context);

assert.ok(
isSettled(),
`out of balance xhr semaphores are cleaned up on teardown: ${getSettledState()}`
);
let state = getSettledState();
assert.equal(state.hasPendingRequests, false, 'hasPendingRequests is false');
assert.equal(state.pendingRequestCount, 0, 'pendingRequestCount is 0');
});
}
});

0 comments on commit 2e2f45c

Please sign in to comment.