Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table of icons #448

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add table of icons #448

wants to merge 4 commits into from

Conversation

jag-k
Copy link

@jag-k jag-k commented Jul 31, 2023

Fix #436

Changes:

  • Refactoring ci.py
  • Added table of icons with filename
  • Added "SVG Support" column

You can see new ICONS.md in PR.

If you want, I can add "cloud of icons" and table in the same ICONS.md

And you can Squash and Merge PR.

Signed-off-by: Jag_k <30597878+jag-k@users.noreply.github.com>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove TEMPLATE.md, 'cause I reuse ICONS.md

Copy link
Owner

@walkxcode walkxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to link the checkmark to the SVG version if it is available?

@jag-k
Copy link
Author

jag-k commented Aug 10, 2023

Would it be possible to link the checkmark to the SVG version if it is available?

Yes, I think I can add a preview and/or direct link to the image (on GitHub and/or cdn).

Which type are you prefer?)

@walkxcode
Copy link
Owner

CDN.

@walkxcode
Copy link
Owner

Hi, are you still working on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Labels to allow searching
2 participants