optimize: reduce unnecessary synchronized (apache#1799)

wangliang181230 · Oct 23, 2019 · 8c80c5c · 8c80c5c
1 parent ab32bee
commit 8c80c5c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/core/src/main/java/io/seata/core/codec/CodecFactory.java b/core/src/main/java/io/seata/core/codec/CodecFactory.java
@@ -39,13 +39,13 @@ public class CodecFactory {
      * @param codec the code
      * @return the codec
      */
-    public static synchronized Codec getCodec(byte codec) {
+    public static Codec getCodec(byte codec) {
         CodecType codecType = CodecType.getByCode(codec);
         if (CODEC_MAP.get(codecType) != null) {
             return CODEC_MAP.get(codecType);
         }
         Codec codecImpl = EnhancedServiceLoader.load(Codec.class, codecType.name());
-        CODEC_MAP.put(codecType, codecImpl);
+        CODEC_MAP.putIfAbsent(codecType, codecImpl);
         return codecImpl;
     }
 

diff --git a/server/src/main/java/io/seata/server/lock/LockerFactory.java b/server/src/main/java/io/seata/server/lock/LockerFactory.java
@@ -67,7 +67,7 @@ public class LockerFactory {
      *
      * @return the lock manager
      */
-    public static synchronized final LockManager getLockManager() {
+    public static final LockManager getLockManager() {
         return lockManager;
     }
 
@@ -77,7 +77,7 @@ public static synchronized final LockManager getLockManager() {
      * @param branchSession the branch session
      * @return the lock manager
      */
-    public static synchronized final Locker get(BranchSession branchSession) {
+    public static final Locker get(BranchSession branchSession) {
         String storeMode = CONFIG.getConfig(ConfigurationKeys.STORE_MODE);
         if (StoreMode.DB.name().equalsIgnoreCase(storeMode)) {
             if (lockerMap.get(storeMode) != null) {
@@ -90,7 +90,7 @@ public static synchronized final Locker get(BranchSession branchSession) {
             DataSource logStoreDataSource = dataSourceGenerator.generateDataSource();
             locker = EnhancedServiceLoader.load(Locker.class, storeMode, new Class[] {DataSource.class},
                 new Object[] {logStoreDataSource});
-            lockerMap.put(storeMode, locker);
+            lockerMap.putIfAbsent(storeMode, locker);
         } else if (StoreMode.FILE.name().equalsIgnoreCase(storeMode)) {
             locker = EnhancedServiceLoader.load(Locker.class, storeMode,
                 new Class[] {BranchSession.class}, new Object[] {branchSession});