Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bazel files #108

Merged
merged 1 commit into from
Feb 5, 2020
Merged

add bazel files #108

merged 1 commit into from
Feb 5, 2020

Conversation

joesonw
Copy link
Contributor

@joesonw joesonw commented Jan 14, 2020

add bazel related files for those who want to use this project seamlessly in bazel projects.

@joesonw joesonw requested a review from Hywan January 20, 2020 10:39
load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")

http_archive(
name = "io_bazel_rules_go",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Babel. What that does?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel is a build tool, I think from Google

go_register_toolchains()

http_archive(
name = "bazel_gazelle",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above: What is it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems is autogenerated from bazel rules-go:

https://github.com/bazelbuild/rules_go

WORKSPACE Show resolved Hide resolved
WORKSPACE Show resolved Hide resolved
WORKSPACE Show resolved Hide resolved
@Hywan
Copy link
Contributor

Hywan commented Feb 5, 2020

bors r+

@Hywan Hywan merged commit 821d826 into wasmerio:master Feb 5, 2020
@Hywan Hywan self-assigned this Feb 5, 2020
@Hywan Hywan added 🎉 enhancement New feature or request 🧪 tests I love tests labels Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature or request 🧪 tests I love tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants