fix(go) Force go mod vendor to copy the packaged/ directory.
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in golang/go#26366, `go mod vendor` is acting unexpectely. If a directory doesn't contain a `.go` file, then it's not copied. This patch fixes that.
jubianchi
approved these changes
Feb 11, 2021
|
bors try |
tryBuild failed: |
|
Can confirm this allows you to vendor wasmer-go properly 👍🏼 |
|
Thanks! |
|
bors try |
tryBuild failed: |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #196.
As explained in golang/go#26366,
go mod vendoris acting unexpectely. If a directory doesn't contain a.gofile, then it's not copied.
This patch fixes that. Or try to.
It's not tested on the CI because it's not that easy. We would need to create a new Go project, requiring
wasmer-go,go mod vendor, then having small test inside this project that useswasmer-go. If everything works correctly, then it's good.For the moment, the patch will be tested by @cohix!