feat(config) Add the CompilerKind and EngineKind types

[Hywan]

This patch introduces the CompilerKind and EngineKind types.

This patch also introduces the IsCompilerAvailable and IsEngineAvailable functions. They must be used to check whether a specific compiler or engine is available, otherwise the Config.Use*Compiler or Config.Use*Engine may panic.

This patch also fixes a bug with the Config.Use*Compiler methods where the wasm_config_set_engine function was called instead of wasm_config_set_compiler.

[Hywan]

bors try

[bors]

try

Build succeeded:

• Build and Test (1.14, linux-amd64, ubuntu-18.04)
• Build and Test (1.14, darwin-amd64, macos-latest)
• Build and Test (1.15, darwin-amd64, macos-latest)
• Build and Test (1.14, linux-aarch64, self-hosted, linux, ARM64)
• Build and Test (1.15, linux-aarch64, self-hosted, linux, ARM64)
• Build and Test (1.15, linux-amd64, ubuntu-18.04)

[jubianchi]

Seems good to me, I would just have added a test for IsCompilerAvailable but it may only introduce code duplication 🤔

[Hywan]

Yeah, it's not that simple to test actually. I consider that if the TestConfig_AllCombinations test passes, then it's fine enough for the moment (

wasmer-go/wasmer/config_test.go

Lines 29 to 91 in 9ea145a

	func TestConfig_AllCombinations(t *testing.T) {
	type Test struct {
	compilerName string
	engineName string
	config *Config
	}
	var configs = []Test{}
	is_amd64 := runtime.GOARCH == "amd64"
	//is_aarch64 := runtime.GOARCH == "arm64"
	is_linux := runtime.GOOS == "linux"
	is_darwin := runtime.GOOS == "darwin"
	//is_windows := runtime.GOOS == "windows"
	// Cranelift with the JIT engine works everywhere
	configs = append(configs, Test{"Cranelift", "JIT", NewConfig().UseCraneliftCompiler().UseJITEngine()})
	// Cranelift with the Native engine works on Linux+Darwin/amd64.
	if is_amd64 && (is_linux || is_darwin) {
	configs = append(configs, Test{"Cranelift", "Native", NewConfig().UseCraneliftCompiler().UseNativeEngine()})
	}
	/*
	LLVM isn't part of the prepacked `libwasmer` for the moment.
	// LLVM with the JIT engine works on Linux+Darwin/amd64.
	if is_amd64 && (is_linux || is_darwin) {
	configs = append(configs, Test{"LLVM", "JIT", NewConfig().UseLLVMCompiler().UseJITEngine()})
	}
	// LLVM with the Native engine works on Linux+Darwin/amd64.
	if is_amd64 && (is_linux || is_darwin) {
	configs = append(configs, Test{"LLVM", "Native", NewConfig().UseLLVMCompiler().UseNativeEngine()})
	}
	*/
	// Singlepass with the JIT engine works on Linux+Darwin/amd64.
	if is_amd64 && (is_linux || is_darwin) {
	configs = append(configs, Test{"Singlepass", "JIT", NewConfig().UseSinglepassCompiler().UseJITEngine()})
	}
	for _, test := range configs {
	t.Run(
	fmt.Sprintf("compiler=%s, engine=%s", test.compilerName, test.engineName),
	func(t *testing.T) {
	engine := NewEngineWithConfig(test.config)
	store := NewStore(engine)
	module, err := NewModule(store, testGetBytes("tests.wasm"))
	assert.NoError(t, err)
	instance, err := NewInstance(module, NewImportObject())
	assert.NoError(t, err)
	sum, err := instance.Exports.GetFunction("sum")
	assert.NoError(t, err)
	result, err := sum(37, 5)
	assert.NoError(t, err)
	assert.Equal(t, result, int32(42))
	},
	)
	}
	}

).

[Hywan]

bors r+

[bors]

Build succeeded:

• Build and Test (1.14, darwin-amd64, macos-latest)
• Build and Test (1.14, linux-aarch64, self-hosted, linux, ARM64)
• Build and Test (1.14, linux-amd64, ubuntu-18.04)
• Build and Test (1.15, darwin-amd64, macos-latest)
• Build and Test (1.15, linux-aarch64, self-hosted, linux, ARM64)
• Build and Test (1.15, linux-amd64, ubuntu-18.04)