correctly handle I64 (and other) values returned from imported functions #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
approved these changes
Mar 18, 2021
bors bot
added a commit
that referenced
this pull request
Mar 18, 2021
242: correctly handle I64 (and other) values returned from imported functions r=Hywan a=noot I was attempting to upgrade to the new wasmer version when I found that any imported functions that returned I64 caused "panic: Cannot convert value to `int32`". it seems it was due to always trying to convert the return value to I32. This PR resolves that issue. Co-authored-by: noot <elizabethjbinks@gmail.com>
|
Do you need a new release now? |
|
@Hywan I can point to the commit for now, so not an issue, up to you :) |
|
I'll make a new release probably today :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was attempting to upgrade to the new wasmer version when I found that any imported functions that returned I64 caused "panic: Cannot convert value to
int32". it seems it was due to always trying to convert the return value to I32. This PR resolves that issue.