Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to nestjs 7 #32

Merged
merged 4 commits into from
Oct 16, 2021
Merged

Upgrade to nestjs 7 #32

merged 4 commits into from
Oct 16, 2021

Conversation

vip30
Copy link
Contributor

@vip30 vip30 commented Jul 15, 2020 •
edited
Loading

Base on the migration guide,
seems don't have to do anything except updating the dependency

This time I didn't change the package version and change the nestjs dependency only
Just wonder if it is correct or not.

Thanks

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 99.007% when pulling 3cddaf1 on vip30:master into 9113afc on wbhob:master.

@wbhob
Copy link
Owner

wbhob commented Sep 14, 2020

have you tested these changes locally? ie you built locally and npm installed them?

@vip30
Copy link
Contributor Author

vip30 commented Sep 24, 2020

yes already tried and seems everything ok

@wbhob wbhob merged commit ca9193e into wbhob:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vip30 @coveralls @wbhob