Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding provider to convert #806

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+4 −0
Open

adding provider to convert #806

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5886d8
adding provider to convert
steve-fraser Jan 8, 2024
3654eea
add to creation statement
steve-fraser Jan 8, 2024
638d0ec
fix variable
steve-fraser Jan 8, 2024
af0bcb3
fix provider variable
steve-fraser Jan 8, 2024
03d3230
fix tests
steve-fraser Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix variable
  • Loading branch information
@steve-fraser
steve-fraser committed Jan 8, 2024
commit 638d0ec85f0aee2ff79a6fafe7db40ed4ff0da35
2 changes: 1 addition & 1 deletion infrastructure/grpc/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
VCPU: int64(spec.Vcpu),
MemoryInMb: int64(spec.MemoryInMb),
Metadata: instance.New(),
Provider: spec.Kernel.Provider,
Provider: spec.Provider,

Check failure on line 37 in infrastructure/grpc/convert.go

View workflow job for this annotation

GitHub Actions / test 

cannot use spec.Provider (variable of type *string) as string value in struct literal
},
}

Expand Down
Loading