-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: review code split docs #3921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 775f5a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 215 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
caohuilin
reviewed
Jun 12, 2023
packages/document/main-doc/docs/zh/guides/advanced-features/code-split.mdx
Outdated
Show resolved
Hide resolved
yimingjfe
reviewed
Jun 12, 2023
packages/document/main-doc/docs/en/guides/advanced-features/code-split.mdx
Show resolved
Hide resolved
packages/document/main-doc/docs/en/guides/advanced-features/code-split.mdx
Outdated
Show resolved
Hide resolved
zllkjc
force-pushed
the
chore/docs-review-0608
branch
from
June 12, 2023 11:00
3b908df
to
775f5a2
Compare
yimingjfe
approved these changes
Jun 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at c51f987
This pull request updates the documentation of the code splitting feature in Modern.js for both English and Chinese readers. It fixes errors, clarifies concepts, and provides more relevant examples using
Suspense
,React.lazy
, and Loadable. It also adds a changeset file for the@modern-js/main-doc
package.Details
🤖 Generated by Copilot at c51f987
@modern-js/main-doc
package (link)import()
syntax in both English and Chinese documentation, removing the unnecessary reference to the packaging entry (link, link)React.lazy
with SSR in both English and Chinese documentation, reflecting the latest status of React 18 Streaming SSR and recommending the Loadable API instead (link, link)<Suspense>
in SSR and CSR projects (link, link)Related Issue
Checklist
pnpm run change
.