-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): add catch and imporve url parse logic in modern server #4236
Conversation
🦋 Changeset detectedLatest commit: 7a972e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 263 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4236 +/- ##
==========================================
- Coverage 57.59% 51.03% -6.57%
==========================================
Files 672 665 -7
Lines 17794 18255 +461
Branches 3876 4178 +302
==========================================
- Hits 10249 9316 -933
- Misses 6934 8251 +1317
- Partials 611 688 +77 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at 910c7ce
This pull request fixes a bug in the
@modern-js/prod-server
package that caused incorrect URL parsing and caching. It updates theModernServerContext
class and adds a changeset file for the patch release.Details
🤖 Generated by Copilot at 910c7ce
@modern-js/prod-server
package (link)_parsedURL
of theModernServerContext
class (link)parsedURL
getter method of theModernServerContext
class, using the_parsedURL
property or theURL
constructor with a mock base, and returning a mock URL object with a special path in case of errors (link)Related Issue
Checklist
pnpm run change
.