Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove jest mock #4313

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

targeral
Copy link
Member

@targeral targeral commented Jul 26, 2023

Summary

🤖 Generated by Copilot at be780c6

Removed global mocking of onExit module in inputFilter.test.ts and replaced it with local mocking in each test case. This improves test isolation and avoids conflicts with other tests.

Details

🤖 Generated by Copilot at be780c6

  • Remove global mocking of onExit module and use jest.doMock inside each test case that needs it (link). This improves test isolation and avoids potential conflicts with other tests that use the module.

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: be780c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@targeral targeral requested a review from 10Derozan July 26, 2023 13:15
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -6.59% ⚠️

Comparison is base (99693f0) 57.59% compared to head (be780c6) 51.01%.
Report is 863 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4313      +/-   ##
==========================================
- Coverage   57.59%   51.01%   -6.59%     
==========================================
  Files         672      662      -10     
  Lines       17794    18078     +284     
  Branches     3876     3955      +79     
==========================================
- Hits        10249     9222    -1027     
- Misses       6934     8133    +1199     
- Partials      611      723     +112     

see 403 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenjiahan chenjiahan merged commit 52d9805 into web-infra-dev:main Jul 26, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants