Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename test filename #4316

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

targeral
Copy link
Member

@targeral targeral commented Jul 26, 2023

Summary

🤖 Generated by Copilot at 296869b

Updated and renamed integration tests for input filter feature of modern.js. The tests check that the module bundler correctly excludes files that match the input filter glob pattern.

Details

🤖 Generated by Copilot at 296869b

  • Change input filter for first build configuration to exclude *.a.ts files (link)
  • Rename index.spec.ts to index.a.ts in input filter fixture (link)
  • Update test cases for both build configurations to check output directory and input filter (link, link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: 7ed6d47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

caohuilin
caohuilin previously approved these changes Jul 26, 2023
@caohuilin caohuilin enabled auto-merge (squash) July 26, 2023 15:09
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -6.59% ⚠️

Comparison is base (99693f0) 57.59% compared to head (7ed6d47) 51.01%.
Report is 866 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4316      +/-   ##
==========================================
- Coverage   57.59%   51.01%   -6.59%     
==========================================
  Files         672      662      -10     
  Lines       17794    18078     +284     
  Branches     3876     3955      +79     
==========================================
- Hits        10249     9222    -1027     
- Misses       6934     8133    +1199     
- Partials      611      723     +112     

see 403 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caohuilin caohuilin disabled auto-merge July 26, 2023 15:19
@caohuilin caohuilin enabled auto-merge (squash) July 26, 2023 15:19
@caohuilin caohuilin merged commit cdfead9 into web-infra-dev:main Jul 26, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants