Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): use two separate steps #4966

Merged
merged 1 commit into from
Nov 17, 2023
Merged

chore(workflow): use two separate steps #4966

merged 1 commit into from
Nov 17, 2023

Conversation

Timeless0911
Copy link
Collaborator

@Timeless0911 Timeless0911 commented Nov 17, 2023

Summary

🤖[deprecated] Generated by Copilot at d971634

Updated the bench-pr workflow to support different products and comment triggers. Simplified the workflow dispatch input to use the product name.

Details

🤖[deprecated] Generated by Copilot at d971634

  • Rename and condition trigger step to run framework benchmark workflow on comment (link)
  • Add trigger-module step to run module benchmark workflow on comment (link)
  • Simplify script of both steps to pass product name as input to workflow dispatch (link, link)
  • Change product input of workflow dispatch to match MODERNJS_MODULE product name (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Nov 17, 2023

⚠️ No Changeset found

Latest commit: 4b436c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Timeless0911 Timeless0911 changed the title chore: use two separate steps chore(workflow): use two separate steps Nov 17, 2023
@Timeless0911 Timeless0911 merged commit 955656e into main Nov 17, 2023
7 checks passed
@Timeless0911 Timeless0911 deleted the fix/yaml-syntax branch November 17, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants