Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devtools/client): switch to hash router #5876

Merged
merged 22 commits into from
Jul 10, 2024
Merged

Conversation

Asuka109
Copy link
Collaborator

@Asuka109 Asuka109 commented Jun 25, 2024

Summary

  • Switch the router of @modern-js/devtools-client to hash router, so that the client can be deployed with any pathname.
  • Expose createManifest hook to enable plugins modify the manifest.
  • Initialize React DevTools renderer on plugin/src/runtime.ts.
    • Fix crashing when left and visit the DevTools tab again.
    • Take controll from React DevTools extension.

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: f3c1aec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

zllkjc
zllkjc previously approved these changes Jul 9, 2024
@Asuka109 Asuka109 enabled auto-merge (squash) July 10, 2024 08:28
@Asuka109 Asuka109 disabled auto-merge July 10, 2024 08:41
@zllkjc zllkjc merged commit 7002e03 into main Jul 10, 2024
7 checks passed
@zllkjc zllkjc deleted the feat/devtools-hash-router branch July 10, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants