fix

crates/node_binding/binding.d.ts

@@ -146,8 +146,7 @@ export const enum BuiltinPluginName {
   OldSplitChunksPlugin = 'OldSplitChunksPlugin',
   ContainerPlugin = 'ContainerPlugin',
   ContainerReferencePlugin = 'ContainerReferencePlugin',
-  ShareRuntimePlugin = 'ShareRuntimePlugin',
-  MFScopeRuntimePlugin = 'MFScopeRuntimePlugin',
+  ModuleFederationRuntimePlugin = 'ModuleFederationRuntimePlugin',
   HttpExternalsRspackPlugin = 'HttpExternalsRspackPlugin',
   CopyRspackPlugin = 'CopyRspackPlugin',
   HtmlRspackPlugin = 'HtmlRspackPlugin',

crates/rspack_binding_options/src/options/raw_builtins/mod.rs

@@ -15,7 +15,7 @@ use napi_derive::napi;
 use rspack_core::{
   mf::{
     container_plugin::ContainerPlugin, container_reference_plugin::ContainerReferencePlugin,
-    mf_scope_runtime_plugin::MFScopeRuntimePlugin, share_runtime_plugin::ShareRuntimePlugin,
+    module_federation_runtime_plugin::ModuleFederationRuntimePlugin,
   },
   BoxPlugin, Define, DefinePlugin, PluginExt, Provide, ProvidePlugin,
 };
@@ -80,8 +80,7 @@ pub enum BuiltinPluginName {
   OldSplitChunksPlugin,
   ContainerPlugin,
   ContainerReferencePlugin,
-  ShareRuntimePlugin,
-  MFScopeRuntimePlugin,
+  ModuleFederationRuntimePlugin,
 
   // rspack specific plugins
   HttpExternalsRspackPlugin,
@@ -212,9 +211,8 @@ impl RawOptionsApply for BuiltinPlugin {
           .boxed(),
         );
       }
-      BuiltinPluginName::ShareRuntimePlugin => plugins.push(ShareRuntimePlugin::default().boxed()),
-      BuiltinPluginName::MFScopeRuntimePlugin => {
-        plugins.push(MFScopeRuntimePlugin::default().boxed())
+      BuiltinPluginName::ModuleFederationRuntimePlugin => {
+        plugins.push(ModuleFederationRuntimePlugin::default().boxed())
       }
 
       // rspack specific plugins

crates/rspack_core/src/mf/container/mod.rs

@@ -4,8 +4,7 @@ pub mod container_entry_module_factory;
 pub mod container_exposed_dependency;
 pub mod container_plugin;
 pub mod container_reference_plugin;
-pub mod mf_scope_runtime_module;
-pub mod mf_scope_runtime_plugin;
+pub mod module_federation_runtime_plugin;
 pub mod remote_module;
 pub mod remote_runtime_module;
 pub mod remote_to_external_dependency;

crates/rspack_core/src/mf/container/module_federation_runtime_plugin.rs

@@ -0,0 +1,67 @@
+use rspack_identifier::Identifier;
+use rspack_sources::{BoxSource, RawSource, SourceExt};
+
+use crate::{
+  impl_runtime_module, mf::share_runtime_module::ShareRuntimeModule,
+  AdditionalChunkRuntimeRequirementsArgs, ChunkUkey, Compilation, Plugin,
+  PluginAdditionalChunkRuntimeRequirementsOutput, PluginContext, RuntimeGlobals, RuntimeModule,
+};
+
+#[derive(Debug, Default)]
+pub struct ModuleFederationRuntimePlugin;
+
+impl Plugin for ModuleFederationRuntimePlugin {
+  fn name(&self) -> &'static str {
+    "rspack.ModuleFederationRuntimePlugin"
+  }
+
+  fn runtime_requirements_in_tree(
+    &self,
+    _ctx: PluginContext,
+    args: &mut AdditionalChunkRuntimeRequirementsArgs,
+  ) -> PluginAdditionalChunkRuntimeRequirementsOutput {
+    if args
+      .runtime_requirements
+      .contains(RuntimeGlobals::SHARE_SCOPE_MAP)
+    {
+      args
+        .compilation
+        .add_runtime_module(args.chunk, Box::<ModuleFederationRuntimeModule>::default());
+      args
+        .compilation
+        .add_runtime_module(args.chunk, Box::<ShareRuntimeModule>::default());
+    }
+    Ok(())
+  }
+}
+
+#[derive(Debug, Eq)]
+pub struct ModuleFederationRuntimeModule {
+  id: Identifier,
+  chunk: Option<ChunkUkey>,
+}
+
+impl Default for ModuleFederationRuntimeModule {
+  fn default() -> Self {
+    Self {
+      id: Identifier::from("webpack/runtime/mf_scope"),
+      chunk: None,
+    }
+  }
+}
+
+impl RuntimeModule for ModuleFederationRuntimeModule {
+  fn name(&self) -> Identifier {
+    self.id
+  }
+
+  fn generate(&self, _: &Compilation) -> BoxSource {
+    RawSource::from(format!(r#"{}.MF = {{}};"#, RuntimeGlobals::REQUIRE)).boxed()
+  }
+
+  fn attach(&mut self, chunk: ChunkUkey) {
+    self.chunk = Some(chunk);
+  }
+}
+
+impl_runtime_module!(ModuleFederationRuntimeModule);

crates/rspack_core/src/mf/sharing/mod.rs

@@ -1,2 +1 @@
 pub mod share_runtime_module;
-pub mod share_runtime_plugin;

packages/rspack/src/builtin-plugin/base.ts

@@ -30,8 +30,7 @@ export enum BuiltinPluginName {
 	OldSplitChunksPlugin = "OldSplitChunksPlugin",
 	ContainerPlugin = "ContainerPlugin",
 	ContainerReferencePlugin = "ContainerReferencePlugin",
-	ShareRuntimePlugin = "ShareRuntimePlugin",
-	MFScopeRuntimePlugin = "MFScopeRuntimePlugin",
+	ModuleFederationRuntimePlugin = "ModuleFederationRuntimePlugin"
 }
 
 export abstract class RspackBuiltinPlugin implements RspackPluginInstance {

packages/rspack/src/container/ContainerReferencePlugin.ts

@@ -8,6 +8,7 @@ import { ExternalsPlugin } from "../builtin-plugin/ExternalsPlugin";
 import { ExternalsType } from "../config";
 import { parseOptions } from "./options";
 import { RemoteRuntimeSingletonPlugin } from "./RemoteRuntimeSingletonPlugin";
+import { ShareRuntimeSingletonPlugin } from "../sharing/ShareRuntimeSingletonPlugin";
 
 export type ContainerReferencePluginOptions = {
 	remoteType: ExternalsType;
@@ -65,6 +66,7 @@ export class ContainerReferencePlugin extends RspackBuiltinPlugin {
 			}
 		}
 		new ExternalsPlugin(remoteType, remoteExternals).apply(compiler);
+		new ShareRuntimeSingletonPlugin().apply(compiler);
 		new RemoteRuntimeSingletonPlugin().apply(compiler);
 
 		return {

packages/rspack/src/container/ModuleFederationRuntimePlugin.ts

@@ -0,0 +1,17 @@
+import { Compiler } from "../Compiler";
+import { BuiltinPluginName, create } from "../builtin-plugin/base";
+
+const ModuleFederationRuntimePlugin2 = create(
+	BuiltinPluginName.ModuleFederationRuntimePlugin,
+	() => undefined
+);
+
+export class ModuleFederationRuntimePlugin {
+	apply(compiler: Compiler) {
+		// TODO: a hack to make sure this runtime is added after ContainerReferencePlugin
+		// remove afterPlugin once we make rust side runtime_requirements_in_tree "tapable"
+		compiler.hooks.afterPlugins.tap("ModuleFederationRuntimePlugin", () => {
+			new ModuleFederationRuntimePlugin2().apply(compiler);
+		});
+	}
+}

packages/rspack/src/container/RemoteRuntimeSingletonPlugin.ts

@@ -1,18 +1,17 @@
 import { Compiler } from "../Compiler";
 import { EntryPlugin } from "../builtin-plugin/EntryPlugin";
-import { ShareRuntimeSingletonPlugin } from "../sharing/ShareRuntimeSingletonPlugin";
-import { MFScopeRuntimeSingletonPlugin } from "./MFScopeRuntimeSingletonPlugin";
 
 let added = false;
 
 export class RemoteRuntimeSingletonPlugin {
 	apply(compiler: Compiler) {
-		new MFScopeRuntimeSingletonPlugin().apply(compiler);
-		new ShareRuntimeSingletonPlugin().apply(compiler);
 		if (added) return;
 		added = true;
 		new EntryPlugin(compiler.context, require.resolve("./remotesLoading.js"), {
 			name: undefined
 		}).apply(compiler);
+		compiler.hooks.done.tap(RemoteRuntimeSingletonPlugin.name, () => {
+			added = false;
+		});
 	}
 }

packages/rspack/src/rspackOptionsApply.ts

@@ -38,6 +38,7 @@ import {
 	SplitChunksPlugin,
 	OldSplitChunksPlugin
 } from "./builtin-plugin";
+import { ModuleFederationRuntimePlugin } from "./container/ModuleFederationRuntimePlugin";
 
 export function optionsApply_compat(
 	compiler: Compiler,
@@ -173,6 +174,8 @@ export class RspackOptionsApply {
 		);
 		compiler.hooks.entryOption.call(options.context, options.entry);
 
+		new ModuleFederationRuntimePlugin().apply(compiler);
+
 		const { minimize, minimizer } = options.optimization;
 		if (minimize && minimizer) {
 			for (const item of minimizer) {

packages/rspack/src/sharing/ShareRuntimeSingletonPlugin.ts

@@ -1,25 +1,19 @@
 import { Compiler } from "../Compiler";
 import { EntryPlugin } from "../builtin-plugin/EntryPlugin";
-import { BuiltinPluginName, create } from "../builtin-plugin/base";
-import { MFScopeRuntimeSingletonPlugin } from "../container/MFScopeRuntimeSingletonPlugin";
-
-const ShareRuntimePlugin = create(
-	BuiltinPluginName.ShareRuntimePlugin,
-	() => undefined
-);
 
 let added = false;
 
 export class ShareRuntimeSingletonPlugin {
 	apply(compiler: Compiler) {
-		new MFScopeRuntimeSingletonPlugin().apply(compiler);
 		if (added) return;
 		added = true;
-		new ShareRuntimePlugin().apply(compiler);
 		new EntryPlugin(
 			compiler.context,
 			require.resolve("./initializeSharing.js"),
 			{ name: undefined }
 		).apply(compiler);
+		compiler.hooks.done.tap(ShareRuntimeSingletonPlugin.name, () => {
+			added = false;
+		});
 	}
 }