-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate JavaScript API (part 2) #6859
Merged
Merged
+363
−386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
labels
Jun 19, 2024
✅ Deploy Preview for rspack canceled.
|
!eco-ci |
h-a-n-a
force-pushed
the
feat/deprecate-apis
branch
from
June 19, 2024 12:03
356ff50
to
01dc5bc
Compare
cc @9aoy |
LingyuCoder
approved these changes
Jun 19, 2024
2 tasks
h-a-n-a
added
the
release: breaking change
release: breaking change related release(mr only)
label
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: breaking change
release: breaking change related release(mr only)
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed
Compilation.currentNormalModuleHooks
and mark most of the fields as readonly.Check out https://github.com/web-infra-dev/rspack/pull/6859/files#diff-d9855ab929a2eaf55ae2836e14953cbcbb409dae7e76183b335068dc21076043 for detailed changes.
closes #6569
Checklist