fix: align parser.walk_expression to webpack, which put into context_dependency_helper
#6963
+87
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
CPunisher
force-pushed
the
fix/context-dependency
branch
from
daba9d5
to
3cdae65
Compare
|
Do you need a double check? @ahabhgk |
ahabhgk
requested changes
Jun 28, 2024
| } | ||
|
|
||
| impl<'a, F: FnMut(&Expr)> Visit for BasicEvaluatedExpressionVisitor<'a, F> { | ||
| fn visit_expr(&mut self, n: &Expr) { |
There was a problem hiding this comment.
Walk is different with swc visitor, parser plugins' goal is replace all the swc visitors, so this needs to rewrite to walk_expression
There was a problem hiding this comment.
🤔 I use this visitor to find the Expr ast node corresponding to the BasicEvaluatedExpression and then call parser.walk_expression. how would this visitor be rewritten to walk_expression?
There was a problem hiding this comment.
I think there could have some walk around to implement this and avoid the life time issue, I will take a look next week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #6874
The cause of the problem is the direct walking of import call expression, which led to a conflict between the replacement generated by this walk and the replacement handled by ConstPlugin.
Webpack handles the import call expression in three cases:
TemplateLiteral: walk the parts with odd indices, see https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/dependencies/ContextDependencyHelpers.js#L151
Wrapped expr: process the inner expressions, see https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/dependencies/ContextDependencyHelpers.js#L218
Other cases: directly walk the import call expression, see https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/dependencies/ContextDependencyHelpers.js#L241
My solution is to use a visitor to traverse the expression and find the corresponding
ExprforBasicEvaluatedExpressionVisitorbased on span. A better solution might be to add a reference to the correspondingExprforBasicEvaluatedExpressionVisitorlike webpack does. I tried this but couldn't resolve the lifetime issues.Checklist