Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align source name conflict handling #6993

Merged
merged 10 commits into from
Jul 2, 2024
Merged

fix: align source name conflict handling #6993

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a264405
Remove useless mediate var
CPunisher Jun 30, 2024
e639090
Fix source name conflict detection
CPunisher Jul 1, 2024
d9a8828
Add testcase
CPunisher Jul 1, 2024
36408fb
Fix clippy
CPunisher Jul 1, 2024
e84f230
Fix typo
CPunisher Jul 1, 2024
5607906
Sort module_to_source_name before handling conflict
CPunisher Jul 1, 2024
1351b01
Update and align testcase with mini-css-extract-plugin
CPunisher Jul 1, 2024
7f7a0b2
Merge branch 'main' into fix/sourcemap-dedup
SyMind Jul 2, 2024
e7e72bf
Merge branch 'main' into fix/sourcemap-dedup
SyMind Jul 2, 2024
a90e996
fix: directly collect HashMap
SyMind Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@CPunisher
CPunisher committed Jul 1, 2024
commit e84f230d9cd7fba51a459ca43d7ebec48d0bd512
2 changes: 1 addition & 1 deletion crates/rspack_plugin_devtool/src/source_map_dev_tool_plugin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ impl SourceMapDevToolPlugin {
for source in sources {
let module_or_source = source_map_modules
.get(source.as_ref())
.expect("Shoud have module or source");
.expect("expected a module or source");
let source_name = module_to_source_name
.get(module_or_source)
.expect("expected a filename at the given index but found None")
Expand Down