Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nmf resolve hook #6998

Merged
merged 4 commits into from
Jul 2, 2024
Merged

feat: support nmf resolve hook #6998

merged 4 commits into from
Jul 2, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Jul 1, 2024

Summary

support nmf resolve hook:

  • rust side: full support
  • js side: limited support, only support modify resolveData in the hook, return any value (1. false to ignore the request, 2. module instance) are not supported for now

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 1, 2024
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jul 1, 2024
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 4babb91
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6683762ac9cee600080801a9
😎 Deploy Preview https://deploy-preview-6998--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahabhgk ahabhgk enabled auto-merge (squash) July 1, 2024 09:38
@ahabhgk ahabhgk requested a review from SyMind July 1, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants