Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove identifier.js ts-expect-error #7132

Merged
merged 6 commits into from
Jul 12, 2024
Merged

refactor: remove identifier.js ts-expect-error #7132

merged 6 commits into from
Jul 12, 2024
+86 −84

Conversation

SoonIter
Copy link
Member

Summary

#4640

@netlify Netlify
Copy link

netlify bot commented Jul 12, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 47d86ba
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66911df83c3da70008e7f41b

@SoonIter
Copy link
Member Author

😄 I just found that there will be so many vulnerabilities in webpack codes during migrating to ts

chenjiahan
chenjiahan reviewed Jul 12, 2024
View reviewed changes
packages/rspack/src/util/identifier.ts Outdated Show resolved Hide resolved
packages/rspack/src/util/identifier.ts Outdated Show resolved Hide resolved
packages/rspack/src/util/identifier.ts Outdated Show resolved Hide resolved
packages/rspack/src/util/identifier.ts Outdated Show resolved Hide resolved
@SoonIter SoonIter mentioned this pull request Jul 12, 2024
Merged
@SoonIter SoonIter requested a review from chenjiahan July 12, 2024 10:49
@chenjiahan chenjiahan merged commit 7b5ffd5 into web-infra-dev:main Jul 12, 2024
29 checks passed
@chenjiahan
Copy link
Member

👍🏻

@SoonIter SoonIter mentioned this pull request Jul 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SoonIter @chenjiahan