Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Paint ::selection foreground over other pseudos
This CL paints ::selection foreground overlay following the spec that says it should be painted on top (see https://drafts.csswg.org/css-pseudo-4/#highlight-text). Although this is not a complete fix that takes the code to comply with the specifications, it makes it closer to them and it fixes cases like the one in the example "Selecting highlighted text" from the set of examples hosted here https://codepen.io/dazabani13/pen/KKqzOJp (note that the example requires the flag --experimental-web-platform-features to be enabled to see the highlights). Also rebaselined tests that were painting underline squiggles over text when it actually should be below (see https://www.w3.org/TR/css-text-decor/#painting-order). Bug: 1147859 Change-Id: Ie150fe3861807fcb74343d7371f1ee7009745272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3155369 Commit-Queue: Fernando Fiori <ffiori@microsoft.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Dan Clark <daniec@microsoft.com> Reviewed-by: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/main@{#922211}
- Loading branch information