Skip to content

Commit

Permalink
Rename private address space overrides ports in tests
Browse files Browse the repository at this point in the history
The tests still use "private" as the internal naming because the specific spec they are testing, is awaiting a decision on whether to call it "private" or "local".
  • Loading branch information
atjn committed Jun 29, 2024
1 parent 71b96ef commit 8ab6ec6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions fetch/private-network-access/resources/support.sub.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@ async function postMessageAndAwaitReply(target, message) {
const SERVER_PORTS = {
"http": {
"local": {{ports[http][0]}},
"private": {{ports[http-private][0]}},
"private": {{ports[http-local][0]}},
"public": {{ports[http-public][0]}},
},
"https": {
"local": {{ports[https][0]}},
"other-local": {{ports[https][1]}},
"private": {{ports[https-private][0]}},
"private": {{ports[https-local][0]}},
"public": {{ports[https-public][0]}},
},
"ws": {
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/assumptions/non-local-ports.sub.window.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// More tests can be found in `fetch/private-network-access/`.

const alternatePorts = {
httpPrivate: "{{ports[http-private][0]}}",
httpPrivate: "{{ports[http-local][0]}}",
httpsPrivate: "{{ports[https-private][0]}}",
httpPublic: "{{ports[http-public][0]}}",
httpsPublic: "{{ports[https-public][0]}}",
Expand Down

0 comments on commit 8ab6ec6

Please sign in to comment.