[css-transitions] transition-behavior: allow-discrete; work incorrectly in Safari 17.5 and Firefox Nightly with 100% test passing #46753
Comments
alkorlos
changed the title
|
I filed a WebKit bug to look into this. If it is indeed a bug, a fix will include a WPT test. |
webkit-commit-queue
pushed a commit
to graouts/WebKit
that referenced
this issue
Jun 30, 2024
…ome for Developers blog https://bugs.webkit.org/show_bug.cgi?id=275994 Reviewed by Tim Nguyen. Historically, setting `display: none` on an element would cancel any running transition. However, with the addition of `transition-behavior: allow-discrete` and the fact `display` supports discrete animation, setting `display: none` if that value is being transitioned should not cancel running transitions. On top of that, after canceling running transitions, we'd bail out of considering any further transition, so we would fail to transition the `display` value itself. We now correctly handle this case by checking in `Styleable::updateCSSTransitions()` whether setting `display: none` will yield a transition before canceling running transitions and bailing out of that method. This was not covered by existing WPT tests, as noted in web-platform-tests/wpt#46753, so we're adding a new WPT test that checks that we do not cancel running transitions when setting `display: none` when `display` is getting transitioned. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/CSSTransition-not-canceling.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/CSSTransition-not-canceling.tentative.html: Added. * Source/WebCore/style/Styleable.cpp: (WebCore::Styleable::updateCSSTransitions const): Canonical link: https://commits.webkit.org/280512@main
|
Fixed by #46944, this should be fixed in WebKit now too Fwiw, the example is not working in Firefox, because Firefox doesn't support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Recently browsers has been active work on implementing the property
transition-behaviorwith the valueallow-discrete. Six tests have been written for this property, all of which pass in stable versions of Chrome and Safari, as well as in Firefox Nightly.This property allows specifies transitions for discrete properties, with the most obvious example being
display: none;. Despite achieving 100% test passing, the example (from chrome blog) fordisplay: none;does not work correct in Safari 17.5 and Firefox Nightly. Is it possible that more tests are needed?The text was updated successfully, but these errors were encountered: