Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interfaces/css-typed-om.idl #12808

Merged

Conversation

autofoolip
Copy link
Contributor

@autofoolip autofoolip commented Sep 3, 2018

This PR was automatically created by a bot.

Before merging, please check that any tests that depend on the updated IDL files still work.

If additional changes are needed, please manually create another PR based on this one.

See the README for how the IDL files in this directory are used.


Source: https://github.com/tidoust/reffy-reports/blob/398ec92/whatwg/idl/css-typed-om.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/423853333

@foolip
Copy link
Member

foolip commented Sep 3, 2018

This change is from w3c/css-houdini-drafts@5261c1a. @tabatkins, is it still on some other level? It's still in https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/css/cssom/css_position_value.idl, FWIW.

@autofoolip autofoolip changed the title Update interfaces/css-typed-om.idl Update interfaces/css-typed-om.idl Sep 9, 2018
@foolip
Copy link
Member

foolip commented Sep 9, 2018

Ping @tabatkins on the fate of CSSPositionValue. Note that it's still in https://github.com/w3c/css-houdini-drafts/blob/03743d14fcecb2c3700e7002a92d9283f5bb8a17/css-typed-om/README.md.

@autofoolip autofoolip changed the title Update interfaces/css-typed-om.idl Update interfaces/css-typed-om.idl Sep 9, 2018
@tabatkins
Copy link
Contributor

No, it's been removed from this level due to it being known to be inconsistent with already-specced upgrades to <position> values (to accommodate logical directions). The design assumed that the position could always be expressed in physical coordinates, which absolutely isn't true for specified values, and isn't necessarily true even for computed values.

I need to remove it from some other places that still reference it, but it won't return until we fix the object's shape.

@foolip
Copy link
Member

foolip commented Sep 10, 2018

@tabatkins, can you file bugs for unshipping the interface in Chrome and removing tests for it here in WPT?

@tabatkins
Copy link
Contributor

yeah

@foolip foolip merged commit 3b72e3f into web-platform-tests:master Sep 11, 2018
@autofoolip autofoolip deleted the reffy-reports/css-typed-om branch September 11, 2018 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants